This repository has been archived by the owner on Nov 2, 2020. It is now read-only.
Add caution to the i18n doc about embedded vars not being autoescaped #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ovidiu. |
fabpot
added a commit
that referenced
this pull request
Aug 6, 2019
…autoescaped (Ovidiu Curcan) This PR was merged into the 2.0-dev branch. Discussion ---------- Add caution to the i18n doc about embedded vars not being autoescaped This relates to #241: variables embedded in `{% trans %}` tags are not subject to automatic escaping. I believe Twig users will reasonably expect to be safe by default, unless they opt out of it using `|raw`. I found out about this behavior after penetration testing was performed on an application I work on. I worry others may find out the hard way. Commits ------- a86ae9d Add caution to the i18n doc about embedded vars not being autoescaped
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #241: variables embedded in
{% trans %}tags are not subject to automatic escaping.I believe Twig users will reasonably expect to be safe by default, unless they opt out of it using
|raw.I found out about this behavior after penetration testing was performed on an application I work on. I worry others may find out the hard way.