Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention where named arguments are supported #3849

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

mpdude
Copy link
Contributor

@mpdude mpdude commented Jun 9, 2023

This follows up on #929. I tend to forget this detail, so it confuses me over and over again.

@@ -204,6 +204,9 @@ built-in functions.
Named Arguments
---------------

Named arguments are supported in functions,
filters and tests.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line break should be removed. It breaks much too early.

@stof
Copy link
Member

stof commented Jun 9, 2023

the 1.x branch is not maintained anymore.

@mpdude mpdude changed the base branch from 1.x to 2.x June 9, 2023 11:18
@mpdude
Copy link
Contributor Author

mpdude commented Jun 9, 2023

Rebased onto 2.x and review comments addressed.

I should have known 1.x is unsupported. I was mislead because in the documentation, it says "... switch to documentation for Twig 1.x, Twig 2.x` in a way that suggests also 1.x receives (documentation) updates.

@fabpot
Copy link
Contributor

fabpot commented Jun 12, 2023

Thank you @mpdude.

@fabpot fabpot merged commit 7f4f555 into twigphp:2.x Jun 12, 2023
@mpdude mpdude deleted the patch-1 branch June 12, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants