chore: pr fixes

twilio-labs · Jan 26, 2024 · 2430c9a · 2430c9a
1 parent 4831546
commit 2430c9a
Show file tree

Hide file tree

Showing 10 changed files with 17 additions and 5 deletions.
diff --git a/.changeset/grumpy-islands-sell.md b/.changeset/grumpy-islands-sell.md
@@ -3,3 +3,4 @@
 ---
 
 [Codemods] added a new package: page-header
+[Codemods] added a new package: SummaryDetail
diff --git a/.codesandbox/ci.json b/.codesandbox/ci.json
@@ -91,6 +91,7 @@
     "/packages/paste-core/components/status",
     "/packages/paste-style-props",
     "/packages/paste-libraries/styling",
+    "/packages/paste-core/components/summary-detail",
     "/packages/paste-core/components/switch",
     "/packages/paste-libraries/syntax-highlighter",
     "/packages/paste-core/components/table",

diff --git a/packages/paste-codemods/tools/.cache/mappings.json b/packages/paste-codemods/tools/.cache/mappings.json
@@ -253,6 +253,12 @@
   "StatusMenuItemRadio": "@twilio-paste/core/status",
   "StatusObject": "@twilio-paste/core/status",
   "useStatusMenuState": "@twilio-paste/core/status",
+  "SummaryDetail": "@twilio-paste/core/summary-detail",
+  "SummaryDetailContent": "@twilio-paste/core/summary-detail",
+  "SummaryDetailHeading": "@twilio-paste/core/summary-detail",
+  "SummaryDetailHeadingContent": "@twilio-paste/core/summary-detail",
+  "SummaryDetailToggleButton": "@twilio-paste/core/summary-detail",
+  "useSummaryDetailState": "@twilio-paste/core/summary-detail",
   "Switch": "@twilio-paste/core/switch",
   "SwitchGroup": "@twilio-paste/core/switch",
   "TBody": "@twilio-paste/core/table",

diff --git a/packages/paste-core/components/summary-detail/package.json b/packages/paste-core/components/summary-detail/package.json
@@ -2,7 +2,7 @@
   "name": "@twilio-paste/summary-detail",
   "version": "0.0.1",
   "category": "interaction",
-  "status": "alpha",
+  "status": "production",
   "description": "A Summary Detail is a collapsible container that can be used to hide or show content.",
   "author": "Twilio Inc.",
   "license": "MIT",

diff --git a/packages/paste-core/components/summary-detail/src/SummaryDetail.tsx b/packages/paste-core/components/summary-detail/src/SummaryDetail.tsx
@@ -18,7 +18,7 @@ export interface SummaryDetailProps extends DisclosurePrimitiveInitialState {
   /**
    * Overrides the default element name to apply unique styles with the Customization Provider
    *
-   * @default 'DISCLOSURE'
+   * @default 'SUMMARY_DETAIL'
    * @type {BoxProps['element']}
    * @memberof SummaryDetailProps
    */

diff --git a/packages/paste-core/components/summary-detail/src/SummaryDetailToggleButton.tsx b/packages/paste-core/components/summary-detail/src/SummaryDetailToggleButton.tsx
@@ -20,8 +20,8 @@ export interface SummaryDetailToggleButtonProps
 
 const ToggleButton = React.forwardRef<HTMLButtonElement, SummaryDetailToggleButtonProps>((props, ref) => {
   const rotation = props["aria-expanded"] ? "90" : "0";
-  // todo make this logic better
-  const labelledby = props["aria-label"] ? undefined : props["aria-labelledby"];
+  // Only use aria-labelledby if aria-label is not provided
+  const ariaLabelledBy = props["aria-label"] ? undefined : props["aria-labelledby"];
 
   return (
     <Button
@@ -33,7 +33,7 @@ const ToggleButton = React.forwardRef<HTMLButtonElement, SummaryDetailToggleButt
       borderRadius="borderRadius20"
       _hover={{ backgroundColor: "colorBackground" }}
       {...props}
-      aria-labelledby={labelledby}
+      aria-labelledby={ariaLabelledBy}
     >
       <Box as="span" element={`${props.element}_ICON_WRAPPER`} transform={`translateX(0) rotate(${rotation}deg)`}>
         <ChevronDisclosureIcon decorative={true} size="sizeIcon30" element={`${props.element}_ICON}`} />

diff --git a/packages/paste-core/core-bundle/.gitignore b/packages/paste-core/core-bundle/.gitignore
@@ -87,6 +87,7 @@
 /status
 /style-props
 /styling-library
+/summary-detail
 /switch
 /syntax-highlighter-library
 /table

diff --git a/packages/paste-core/core-bundle/package.json b/packages/paste-core/core-bundle/package.json
@@ -158,6 +158,7 @@
     "@twilio-paste/status": "^2.1.1",
     "@twilio-paste/style-props": "^9.1.1",
     "@twilio-paste/styling-library": "^3.0.0",
+    "@twilio-paste/summary-detail": "^0.0.1",
     "@twilio-paste/switch": "^5.1.1",
     "@twilio-paste/syntax-highlighter-library": "^3.0.0",
     "@twilio-paste/table": "^8.1.0",

diff --git a/packages/paste-core/core-bundle/src/index.tsx b/packages/paste-core/core-bundle/src/index.tsx
@@ -71,6 +71,7 @@ export * from "@twilio-paste/slider";
 export * from "@twilio-paste/spinner";
 export * from "@twilio-paste/stack";
 export * from "@twilio-paste/status";
+export * from "@twilio-paste/summary-detail";
 export * from "@twilio-paste/switch";
 export * from "@twilio-paste/table";
 export * from "@twilio-paste/tabs";

diff --git a/packages/paste-core/core-bundle/src/summary-detail.tsx b/packages/paste-core/core-bundle/src/summary-detail.tsx
@@ -0,0 +1 @@
+export * from "@twilio-paste/summary-detail";