Skip to content

Commit

Permalink
fix: changeset and comments
Browse files Browse the repository at this point in the history
  • Loading branch information
SiTaggart committed Aug 31, 2022
1 parent fe3d304 commit 50e9a4e
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changeset/old-paws-relate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@twilio-paste/combobox': patch
'@twilio-paste/core': patch
---

[Combobox] Minor fix to controlled Comboboxes, where the input cursor would always jump to the end of the input string in autocomplete examples, even when you want to amend the beginning or middle. Cursor position should now remain in place as you type or modify the input value.
2 changes: 1 addition & 1 deletion packages/paste-core/components/combobox/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export interface ComboboxProps extends Omit<InputProps, 'id' | 'type' | 'value'>
groupItemsBy?: string;
variant?: InputVariants;

// Downshift useCombobox Hook Props
// Downshift useCombobox Hook Props. Thes are mainly covered in https://github.com/downshift-js/downshift/blob/master/src/hooks/useCombobox/README.md#advanced-props docs
initialIsOpen?: UseComboboxPrimitiveProps<any>['initialIsOpen'];
initialSelectedItem?: UseComboboxPrimitiveProps<any>['initialSelectedItem'];
items: UseComboboxPrimitiveProps<any>['items'];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,14 @@ This function allows you to use your own `jsx` template for the items in the dro

The variant of the Combobox. Available variants are `default` or `inverse`.

##### `getA11yStatusMessage?: () => void`

Useful to compose accessible status messages to assistive technology users, including translations.

##### `getA11ySelectionMessage?: () => void`

Useful to compose accessible status messages to assistive technology users, including translations.

#### State props

These props are used when want to create a Controlled Combobox. They control the state of the Combobox.
Expand Down

0 comments on commit 50e9a4e

Please sign in to comment.