fix(user-dialog): fix missing positioning styles on the user dialog (#…

…3404) * fix(user-dialog): fix missing positioning styles on the user dialog * chore: changeset
twilio-labs · Aug 11, 2023 · 81b4c3f · 81b4c3f
1 parent 8562d79
commit 81b4c3f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/nervous-hats-love.md b/.changeset/nervous-hats-love.md
@@ -0,0 +1,6 @@
+---
+'@twilio-paste/user-dialog': patch
+'@twilio-paste/core': patch
+---
+
+[User Dialog] Fix the positioning of the user dialog by adding back the passing down of calculted styles to Box
diff --git a/packages/paste-core/components/user-dialog/src/UserDialog.tsx b/packages/paste-core/components/user-dialog/src/UserDialog.tsx
@@ -11,11 +11,12 @@ import type {UserDialogProps, UserDialogPopoverProps, UserDialogButtonProps} fro
 import {UserDialogContext} from './UserDialogContainer';
 
 // styled popover for UserDialog Non Modal Dialog Primitive
-const UserDialogPopover = React.forwardRef<HTMLDivElement, UserDialogPopoverProps>((props, ref) => {
+const UserDialogPopover = React.forwardRef<HTMLDivElement, UserDialogPopoverProps>(({style, ...props}, ref) => {
   return (
     <Box
       {...safelySpreadBoxProps(props)}
       ref={ref}
+      style={style}
       boxShadow="shadow"
       borderWidth="borderWidth10"
       borderColor="colorBorderWeaker"

diff --git a/packages/paste-core/components/user-dialog/src/types.ts b/packages/paste-core/components/user-dialog/src/types.ts
@@ -24,9 +24,7 @@ export interface UserDialogUserTextProps extends HTMLPasteProps<'div'> {
   element?: BoxProps['element'];
 }
 
-export interface UserDialogPopoverProps extends HTMLPasteProps<'div'> {
-  element?: BoxProps['element'];
-}
+export type UserDialogPopoverProps = BoxProps;
 
 export type UserDialogStateReturn = NonModalDialogPrimitiveStateReturn;