fix(side-modal): fixed side modal position' (#3106)

* fix(side-modal): set position to fixed to ensure dialog covers longs scrolling pages * chore: changeset
twilio-labs · Mar 22, 2023 · dc07ca4 · dc07ca4
1 parent b47e131
commit dc07ca4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/.changeset/tasty-timers-change.md b/.changeset/tasty-timers-change.md
@@ -0,0 +1,6 @@
+---
+'@twilio-paste/side-modal': patch
+'@twilio-paste/core': patch
+---
+
+[Side Modal] set screen position to fixed to ensure the dialog is always full height in long scrolling screens'
diff --git a/packages/paste-core/components/side-modal/src/SideModalContainer.tsx b/packages/paste-core/components/side-modal/src/SideModalContainer.tsx
@@ -27,6 +27,7 @@ const BaseSideModalContainer: React.FC<React.PropsWithChildren<SideModalContaine
     state ||
     useNonModalDialogPrimitiveState({
       modal: true,
+      unstable_fixed: true,
       ...initialState,
     });