Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input type "disabled" blends input value into background color in Safari #1305

Closed
margusha opened this issue Mar 23, 2021 · 4 comments · Fixed by #1408
Closed

Input type "disabled" blends input value into background color in Safari #1305

margusha opened this issue Mar 23, 2021 · 4 comments · Fixed by #1408
Labels
Type: Bug Something isn't working

Comments

@margusha
Copy link

Thanks for helping make Paste better! Note: For urgent requests, reach out at #help-design-system

Describe the bug
Paste documentation outlines the usage of input with disabled state. In the examples it shows visible value as it is defined in placeholder. When, instead value attribute is used for showing disabled input content, its color blends into background color in safari.

To Reproduce
Steps to reproduce the behavior:

  1. create an new paste project
  2. Use input component with disabled=true and specify value attribute with random content
  3. Check in Safari - the input is invisible, but selectable

Expected behavior
Input value is visible, e.g. uses some other color

Screenshots
Disabled Input component using value attribute to show input content
Screen Shot 2021-03-23 at 10 09 27 AM

disabled input component when selection is highlighted:
Screen Shot 2021-03-23 at 10 10 12 AM

Desktop (please complete the following information):

  • OSX
  • Safari
  • All versions

Additional context
Alternatively if the placeholder is desired approach, should hidden input be used instead to store the value? Quite often you would still expect to get the input value event hough its disabled.

@margusha margusha added the Type: Bug Something isn't working label Mar 23, 2021
@richbachman
Copy link
Contributor

Hi @margusha. Thanks for reaching out about this issue. We'll look into it, and get back to you as soon as possible.

@richbachman
Copy link
Contributor

Hi @margusha I've looked into this one further, and I think I found a solution. I've created a ticket in our backlog so we can get it fixed. We'll update this issue once the fix is deployed.

@TheSisb
Copy link
Contributor

TheSisb commented Apr 15, 2021

Hi @margusha,

Unable to repro on Safari version 14.0.3 (15610.4.3.1.7, 15610) while looking at this example on our doc site: https://paste.twilio.design/components/input#disabled-input

Can you provide your Safari version please?

image

@richbachman
Copy link
Contributor

Hi @margusha,

We have a PR up that fixes this issue: #1408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants