-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): fixed the color of disabled input values #1408
Conversation
🦋 Changeset detectedLatest commit: 09340e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +171 B (0%) Total Size: 522 kB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 09340e8:
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great 🙌🏽! Do we need to include a changeset for combobox as well?
@gloriliale I don't think so since we're just adding a story there. Nothing in the package actually changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just not sure how this works, but the fix seems reasonable devoid of alternatives.
423c96b
to
09340e8
Compare
Fixes: #1305
-webkit-text-fill-color
to css scales and enabled it to usetextColor
tokensInput
value colorTextArea
value colorCombobox
story to have an initial value for VRT