Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): add CopyIcon #235

Merged
merged 3 commits into from
Dec 18, 2019
Merged

feat(icons): add CopyIcon #235

merged 3 commits into from
Dec 18, 2019

Conversation

hharnisc
Copy link
Contributor

Adds the CopyIcon with the same SVG as the internal react component library

image

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@vercel
Copy link

vercel bot commented Dec 18, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/twilio-dsys/paste/6nuteh0x0
🌍 Preview: https://paste-git-fork-hharnisc-feat-add-copy-icon.twilio-dsys.now.sh

hharnisc
hharnisc commented Dec 18, 2019
View reviewed changes
packages/paste-icons/__IconList.tsx
import {LoadingIcon} from './src/LoadingIcon';
import {PlusIcon} from './src/PlusIcon';

interface IconProps {
title?: string;
decorative?: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the instructions outlined here: https://github.com/twilio-labs/paste/blob/master/packages/paste-icons/README.md#how-can-i-contribute-icons

Interesting the tool removed the ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this change is good. The ? there was an oversight.

hharnisc
hharnisc commented Dec 18, 2019
View reviewed changes
packages/paste-icons/src/CopyIcon.tsx
@@ -0,0 +1,43 @@
/**
* This file was automatically generated with @twilio-labs/svg-to-react
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was very smooth!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :D

@serifluous
Copy link
Member

Hey @hharnisc! I'm going to send you an updated SVG tonight. We're going to make the square in the icon more square.

Thanks for being proactive on this!

@hharnisc
Copy link
Contributor Author

Sounds great @serifluous 🙌 I'll update the PR with the new SVG

@hharnisc
Copy link
Contributor Author

@TheSisb I updated the CopyIcon with the approved design (thank you @serifluous 🙌 )

@TheSisb TheSisb merged commit d51d0d2 into twilio-labs:master Dec 18, 2019
@hharnisc hharnisc deleted the feat/add-copy-icon branch December 18, 2019 17:24
This was referenced Jan 7, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSisb TheSisb TheSisb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hharnisc @serifluous @TheSisb