Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): update knobs for select stories #430

Merged
merged 3 commits into from
May 8, 2020

Conversation

andioneto
Copy link
Contributor

This PR removes "selected" and "default" knobs from the <Option /> story grouping, since they are blocked from the API.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@vercel
Copy link

vercel bot commented May 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/twilio-dsys/paste/4yk97p7z2
✅ Preview: https://paste-git-select-component-update-knobs.twilio-dsys.now.sh

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2020

Size Change: 0 B

Total Size: 190 kB

ℹ️ View Unchanged
Filename Size Change
packages/paste-core/components/alert/dist/index.es.js 2.76 kB 0 B
packages/paste-core/components/alert/dist/index.js 2.37 kB 0 B
packages/paste-core/components/anchor/dist/index.es.js 1.02 kB 0 B
packages/paste-core/components/anchor/dist/index.js 663 B 0 B
packages/paste-core/components/button/dist/index.es.js 3.9 kB 0 B
packages/paste-core/components/button/dist/index.js 3.52 kB 0 B
packages/paste-core/components/card/dist/index.es.js 1.1 kB 0 B
packages/paste-core/components/card/dist/index.js 715 B 0 B
packages/paste-core/components/form/dist/index.es.js 8.34 kB 0 B
packages/paste-core/components/form/dist/index.js 7.95 kB 0 B
packages/paste-core/components/heading/dist/index.es.js 1.21 kB 0 B
packages/paste-core/components/heading/dist/index.js 817 B 0 B
packages/paste-core/components/list/dist/index.es.js 1.16 kB 0 B
packages/paste-core/components/list/dist/index.js 765 B 0 B
packages/paste-core/components/modal/dist/index.es.js 2.63 kB 0 B
packages/paste-core/components/modal/dist/index.js 2.23 kB 0 B
packages/paste-core/components/paragraph/dist/index.es.js 225 B 0 B
packages/paste-core/components/paragraph/dist/index.js 266 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.es.js 692 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.js 757 B 0 B
packages/paste-core/components/separator/dist/index.es.js 1.12 kB 0 B
packages/paste-core/components/separator/dist/index.js 732 B 0 B
packages/paste-core/components/spinner/dist/index.es.js 1.8 kB 0 B
packages/paste-core/components/spinner/dist/index.js 1.37 kB 0 B
packages/paste-core/components/truncate/dist/index.es.js 649 B 0 B
packages/paste-core/components/truncate/dist/index.js 711 B 0 B
packages/paste-core/components/typography/dist/index.es.js 1.54 kB 0 B
packages/paste-core/components/typography/dist/index.js 1.55 kB 0 B
packages/paste-core/core-bundle/dist/index.es.js 33.9 kB 0 B
packages/paste-core/core-bundle/dist/index.js 34.1 kB 0 B
packages/paste-core/layout/absolute/dist/index.es.js 475 B 0 B
packages/paste-core/layout/absolute/dist/index.js 524 B 0 B
packages/paste-core/layout/aspect-ratio/dist/index.es.js 1.02 kB 0 B
packages/paste-core/layout/aspect-ratio/dist/index.js 647 B 0 B
packages/paste-core/layout/flex/dist/index.es.js 1.81 kB 0 B
packages/paste-core/layout/flex/dist/index.js 1.4 kB 0 B
packages/paste-core/layout/grid/dist/index.es.js 1.64 kB 0 B
packages/paste-core/layout/grid/dist/index.js 1.23 kB 0 B
packages/paste-core/layout/media-object/dist/index.es.js 508 B 0 B
packages/paste-core/layout/media-object/dist/index.js 544 B 0 B
packages/paste-core/layout/stack/dist/index.es.js 1.31 kB 0 B
packages/paste-core/layout/stack/dist/index.js 912 B 0 B
packages/paste-core/primitives/box/dist/index.es.js 2.13 kB 0 B
packages/paste-core/primitives/box/dist/index.js 2.15 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.es.js 14.2 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.js 14.2 kB 0 B
packages/paste-core/primitives/text/dist/index.es.js 1.62 kB 0 B
packages/paste-core/primitives/text/dist/index.js 1.64 kB 0 B
packages/paste-design-tokens/dist/tokens.common.js 2.4 kB 0 B
packages/paste-design-tokens/dist/tokens.es6.js 2.35 kB 0 B
packages/paste-style-props/dist/index.es.js 1.92 kB 0 B
packages/paste-style-props/dist/index.js 1.96 kB 0 B
packages/paste-theme/dist/index.es.js 6.71 kB 0 B
packages/paste-theme/dist/index.js 6.26 kB 0 B
packages/paste-types/dist/index.es.js 21 B 0 B
packages/paste-types/dist/index.js 34 B 0 B

compressed-size-action

@andioneto andioneto added the Area: Components Related to the component library (core) of this system label May 7, 2020
@andioneto andioneto merged commit dc48f63 into master May 8, 2020
@andioneto andioneto deleted the select-component-update-knobs branch May 8, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Related to the component library (core) of this system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants