chore(disclosure): update styles, add tests, promoto to beta #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richbachman
commented
Jan 27, 2021
richbachman
commented
- Updated Disclosure styles
- File refactor
- Added tests for utils functions
- Promoted to beta
- Updated docs anatomy tables
richbachman
added
the
Area: Components
|
This pull request is being automatically deployed with Vercel (learn more). paste – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste/nkszsho2a paste-theme-designer – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste-theme-designer/7osv7kkia |
🦋 Changeset detectedLatest commit: de0796b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit de0796b:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Size Change: +805 B (0%) Total Size: 355 kB
ℹ️ View Unchanged
|
richbachman
force-pushed
the
disclosure/styles
branch
from
5a1aab6
to
c4286eb
Compare
TheSisb
reviewed
Jan 27, 2021
packages/paste-core/components/disclosure/src/DisclosureContent.tsx
Outdated
Show resolved
Hide resolved
richbachman
force-pushed
the
disclosure/styles
branch
from
c4286eb
to
b5437a2
Compare
richbachman
force-pushed
the
disclosure/styles
branch
from
b5437a2
to
d435268
Compare
BREAKING CHANGE: `style` prop is now being blocked by `safelySpreadBoxProps`, so any additional styles will no longer be rendered.
richbachman
force-pushed
the
disclosure/styles
branch
from
d435268
to
6ba89b7
Compare
richbachman
force-pushed
the
disclosure/styles
branch
from
8433134
to
3b6ef49
Compare
richbachman
force-pushed
the
disclosure/styles
branch
from
3b6ef49
to
de0796b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.