New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(toast): add console z-index patch prop #1287
Conversation
This pull request is being automatically deployed with Vercel (learn more). paste – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste/8Avz9NVksZY9pyS6kQ4AAXUsUu6T paste-theme-designer – ./🔍 Inspect: https://vercel.com/twilio-dsys/paste-theme-designer/2MZFVwA5myqkJ4nZVjyZdQK3L53c |
🦋 Changeset detectedLatest commit: da229bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit da229bf:
|
Size Change: +102 B (0%) Total Size: 513 kB
ℹ️ View Unchanged
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
f40eeb5
to
12304b4
Compare
12304b4
to
44d9f9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Adds a prop to relevant Toast components called
__console_patch
which overrides the z-index token to set one that is higher than the masthead in the console product. This patch is temporary, and will be removed in the future. It is only intended to be used in the Console product, which is why the prop name is described with a two underscore prefix. It should not be used outside of the Console product and doesn't affect our other customers.Contributing to Twilio