fix(input): add margin space0 to fix Safari bug #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richbachman
added
the
Area: Components
🦋 Changeset detectedLatest commit: 492bc65 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +59 B (0%) Total Size: 530 kB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 492bc65:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
richbachman
force-pushed
the
fix/safari-margin
branch
2 times, most recently
from
e5b16f4
to
f3e317f
Compare
TheSisb
approved these changes
May 10, 2021
SiTaggart
approved these changes
May 11, 2021
@SiTaggart here's the storybook preview: https://5e53448165911c0022e68c74-dkgjcugivq.chromatic.com/ |
Nice, looks great |
richbachman
force-pushed
the
fix/safari-margin
branch
from
f3e317f
to
492bc65
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
margin: space0on input, select, and button. It wasn't needed for textarea.I played with adding
all: initialorall: unset, but that also cancelled out things likewidth, even if I set it along with theallshorthand. It made more sense to just add the margin reset.