-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(disclosure): remove wrapping box around heading content #1487
Conversation
🦋 Changeset detectedLatest commit: ee43204 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: -52 B (0%) Total Size: 531 kB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ee43204:
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
82e8a61
to
8dcf705
Compare
This PR removes the wrapper around the
{children}
in the DisclosureHeading. Generally speaking, havingflexGrow=1
on adisplay block
element leads to all kinds of wacky behavior. We generally shouldn't be trying to position the children either, because developers may be attempting all kinds of things and we end up in a game of whack a mole with CSS.This change should not have any breaking changes and makes it possible to position/layout the children any which way the developers want.