feat(date-picker): create package #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d871d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +439 B (0%) Total Size: 555 kB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0d871d9:
|
TheSisb
reviewed
May 26, 2021
| "name": "@twilio-paste/date-picker", | ||
| "version": "0.0.0", | ||
| "category": "user input", | ||
| "status": "alpha", |
There was a problem hiding this comment.
Should we make this prod from now, or in the future ticket?
There was a problem hiding this comment.
👍 I think we're going with production for everything now.
| "tsc": "tsc" | ||
| }, | ||
| "dependencies": { | ||
| "date-fns": "^2.21.3" |
There was a problem hiding this comment.
We can safely remove ^ as you brought up because it will reduce margin for error in consumer installs.
| export type DatePickerProps = Omit<InputProps, 'type'>; | ||
|
|
||
| const DatePicker = React.forwardRef<HTMLInputElement, DatePickerProps>((props, ref) => { | ||
| return <Input type="date" {...props} ref={ref} />; |
There was a problem hiding this comment.
Let's move {...props} to before the type="date" to prevent overrides in JS-land.
| // that Date would automatically be instantiated in UTC+0. | ||
|
|
||
| export const returnDateFormatter = (dateValue: string, dateFormat: string): string => { | ||
| const time = 'T12:00:00-00:00'; |
There was a problem hiding this comment.
This would break if someone, somehow, passed in a dateValue string with time already concatenated.
Maybe consider a check like:
const time = 'T12:00:00-00:00';
export const returnDateFormatter = (dateString: string, dateFormat: string): string => {
let dateValue = dateString;
if (!dateValue.contains("T")) {
dateValue = new Date(dateValue.concat(time));
}
return format(Number(dateValue), dateFormat);
}| <> | ||
| <Label htmlFor={uidDP}>Label</Label> | ||
| <DatePicker id={uidDP} aria-describedby={uidHT} {...props} /> | ||
| <HelpText id={uidHT}>Help text</HelpText> |
There was a problem hiding this comment.
Let's make these examples a little more realistic because we have plans to use stories in Tests, the doc site, and more in the future.
i.e.: HelpText shouldn't be "help text" :P
richbachman
reviewed
May 26, 2021
Comment on lines
31
to
39
| "@twilio-paste/anchor": "^5.0.3", | ||
| "@twilio-paste/box": "^4.0.5", | ||
| "@twilio-paste/combobox": "^7.0.2", | ||
| "@twilio-paste/help-text": "^6.0.3", | ||
| "@twilio-paste/icons": "^5.2.0", | ||
| "@twilio-paste/input": "^3.0.6", | ||
| "@twilio-paste/input-box": "^4.0.4", | ||
| "@twilio-paste/label": "^6.0.3", | ||
| "@twilio-paste/style-props": "^3.0.1", | ||
| "@twilio-paste/styling-library": "^0.3.1", | ||
| "@twilio-paste/text": "^4.0.4", | ||
| "@twilio-paste/theme": "^5.0.1", | ||
| "@twilio-paste/types": "^3.1.1", | ||
| "@twilio-paste/uid-library": "^0.2.1", |
There was a problem hiding this comment.
Are we using anchor, box, combobox, help-text, icons, label, text, or uid-library anywhere other than in stories? If not, we can remove those from here and the devDeps.
There was a problem hiding this comment.
Why don't they need to be dependencies if I'm using them in stories?
There was a problem hiding this comment.
Storybook has been modified in our repository to resolve (read: find) the src files in each of our packages. So it knows how to find Paste dependencies. This makes it easier to manage and use Storybook. This means we can get hot reloads on our changes to code, and also means that we don't need to couple storybook dependencies to the thing we're shipping in each package.
richbachman
reviewed
May 26, 2021
Comment on lines
12
to
13
| // Write date picker stories and export to use in test file | ||
| // Stories: default, one using onChange with formatter function (copy combobox controlled using state story) and render value, replicate input stories |
There was a problem hiding this comment.
Reminder to remove this comment.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
nkrantz
commented
Jun 1, 2021
SiTaggart
reviewed
Jun 2, 2021
nkrantz
force-pushed
the
date-picker-comp
branch
5 times, most recently
from
b28a7cd
to
9a410c4
Compare
nkrantz
commented
Jun 8, 2021
Comment on lines
+81
to
+83
| // Change to pointer cursor on cal icon | ||
| '&::-webkit-calendar-picker-indicator:hover': { | ||
| cursor: props.readOnly || props.disabled ? 'default' : 'pointer', |
There was a problem hiding this comment.
@richbachman made these changes (along with line 58), just want to get someone else's eyes on it before I merge it in to make sure it's the right approach to solving the cursor fix.
richbachman
approved these changes
Jun 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type="time"to Input, Input-box, FormreturnDateFormatterfuncContributing to Twilio