fix(tabs): center align horizontal tabs always #1567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9604bd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: -8 B (0%) Total Size: 555 kB
ℹ️ View Unchanged
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9604bd1:
|
TheSisb
force-pushed
the
tabs/center-align-tab
branch
from
0c2854e
to
828b5e1
Compare
richbachman
reviewed
Jun 14, 2021
| @@ -2,21 +2,11 @@ import * as React from 'react'; | |||
| import {render, screen} from '@testing-library/react'; | |||
| // @ts-ignore typescript doesn't like js imports | |||
| import axe from '../../../../../.jest/axe-helper'; | |||
| import {HorizontalTabsExample, VerticalTabsExample, StateHookExample} from '../stories/index.stories'; | |||
| import {HorizontalTabs, StateHookTabs} from '../stories/index.stories'; | |||
richbachman
reviewed
Jun 14, 2021
|
|
||
| export const HorizontalTabs = (): React.ReactNode => { | ||
| return <HorizontalTabsExample />; | ||
| // @ts-expect-error story |
There was a problem hiding this comment.
Not sure whats better here. Having the @ts-expect-error or having the extra code to exclude the ...Example stories. Thoughts?
There was a problem hiding this comment.
I think I prefer TS hints to say "this is fine" over adding more code, but I don't really have a strong opinion.
There was a problem hiding this comment.
I don't really have a strong opinion on this either. We need a tie-breaker @SiTaggart.
There was a problem hiding this comment.
This may not be a true tie-breaker.
In other stories we type the functional component to return React.ReactNode, which is kinda icky but gets around the type error.
In other places like tests I'm pretty partial to not having to do really extreme typescript things it's being picky about because they're tests but, I'm not sure if that's "artisan" and won't bite us in the bum. In those instances where we explicitly expect the type error, I always forget @ts-expect-error and I think it's probably the best way to go.
Finally, amusing the .story annotations are deprecated anyway https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#hoisted-csf-annotations
There was a problem hiding this comment.
Lol. I guess this is fine then? We could also create our own re-useable type in the future:
type Story<P> = React.FC<P> & {
story: {}
// In the future, the other ones they added to replace story
}
|
Code and VRT look good. Just that one question about the stories. |
richbachman
approved these changes
Jun 16, 2021
SiTaggart
approved these changes
Jun 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All horizontal tab labels are now center aligned. This PR also updates the stories to include inclusive content and VRT the center alignment change.