chore(icons): add theme and color picker icons #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d5b87c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: 0 B Total Size: 633 kB ℹ️ View Unchanged
|
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 7d5b87c 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/60f704dd2d297f00070a1690 😎 Browse the preview: https://deploy-preview-1679--paste-docs.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d5b87c:
|
gloriliale
changed the title
serifluous
approved these changes
Jul 19, 2021
richbachman
approved these changes
Jul 20, 2021
TheSisb
reviewed
Jul 20, 2021
.changeset/moody-lies-fry.md
Outdated
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@twilio-paste/icons': patch | |||
| '@twilio-paste/core': patch | |||
There was a problem hiding this comment.
We don't patch core for icon changes. Icons is the only thing that doesn't also update core.
There was a problem hiding this comment.
ah, good to know! Thanks!
TheSisb
reviewed
Jul 20, 2021
| @@ -66,14 +66,14 @@ const HomeHero: React.FC = () => { | |||
| <Column span={5}> | |||
| <NewComponentBanner> | |||
| <NewComponentBannerBadge>New!</NewComponentBannerBadge> | |||
| <NewComponentBannerText>We just added the Date Picker!</NewComponentBannerText> | |||
| <NewComponentBannerText>Did you know we've got an Alert Dialog?!</NewComponentBannerText> | |||
There was a problem hiding this comment.
You may need to rebase now that you merged this change in another PR. I don't think you intended to make this change in this PR
There was a problem hiding this comment.
Yeah, I mentioned it at the top, twas a mistake- this change is merged in now so hopefully it won't be too much of a problem
gloriliale
force-pushed
the
icons/theme-and-color-picker
branch
from
b70dcd4
to
7d5b87c
Compare
TheSisb
approved these changes
Jul 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new icons: Theme and Color Picker
(branched this off of website/new-banner by accident 😬, will remedy when that branch is merged in to main)