-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(popover): make the close button the first focus always #1720
Conversation
🦋 Changeset detectedLatest commit: cb3e2d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: cb3e2d3 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61080d4d3ce9510008481d9f 😎 Browse the preview: https://deploy-preview-1720--paste-docs.netlify.app |
Size Change: +1 B (0%) Total Size: 617 kB
ℹ️ View Unchanged
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cb3e2d3:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simple fix 👍
In another PR, it was observed that the primary focus when a popover opened may be biased or misleading. I make a change in this PR so that we consistently make the close button the primary focus - no matter the contents of a Popover window.