feat(icons): adding toolbar related icons #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bee0d2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: bee0d2a 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/6130fe4d0408830007ffbe22 😎 Browse the preview: https://deploy-preview-1837--paste-docs.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
SiTaggart
force-pushed
the
icons/toolbar
branch
from
1ea3b42
to
e34d381
Compare
|
Size Change: 0 B Total Size: 634 kB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bee0d2a:
|
TheSisb
approved these changes
Sep 2, 2021
loreina
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
I used the deploy preview to check the icons against the designs on Figma and lgtm 👍 👍 👍
Not sure you want @katieporter to also review this since she designed most of these
gloriliale
force-pushed
the
icons/toolbar
branch
from
e34d381
to
bee0d2a
Compare
|
Friendly reminder to follow up with the people who requested some icons. I think they're listed in the AC :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following 9 icons: