-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: form and display pill group #1879
Conversation
SiTaggart
commented
Sep 21, 2021
- updated visual design for both pill types
- added docs for display pills
- added docs for form pills
🦋 Changeset detectedLatest commit: 80bf9ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d8573c1
to
43bf268
Compare
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: d8573c1 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/614a279e3bf9b2000778be04 😎 Browse the preview: https://deploy-preview-1879--paste-theme-designer.netlify.app |
Size Change: +671 B (0%) Total Size: 638 kB
ℹ️ View Unchanged
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: d8573c1 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/614a279f13a6f400088bf471 😎 Browse the preview: https://deploy-preview-1879--paste-docs.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80bf9ce:
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
43bf268
to
1151af0
Compare
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 80bf9ce 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/614e4d1377ca3c0008225bd5 😎 Browse the preview: https://deploy-preview-1879--paste-theme-designer.netlify.app |
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 80bf9ce 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/614e4d1368a97b00078a042e 😎 Browse the preview: https://deploy-preview-1879--paste-docs.netlify.app |
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
title="Silent demo on keyboard navigation" | ||
></iframe> | ||
</AspectRatio> | ||
</Box> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this video!! Succinct but detailed, and I feel like I got a lot out of it even just watching it the first time! It pairs quite nicely with the list above there. Big win here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good, just had some comments about clarifying a few things, especially in FormPillGroup
packages/paste-core/components/display-pill-group/src/DisplayPillGroup.tsx
Show resolved
Hide resolved
7a42f17
to
e58b361
Compare
15421e5
to
21f0cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just left a few notes
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
title="Silent demo on keyboard navigation" | ||
></iframe> | ||
</AspectRatio> | ||
</Box> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
28efc19
to
8583639
Compare
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/form-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
dbae724
to
6ac5274
Compare
packages/paste-website/src/pages/components/display-pill-group/index.mdx
Outdated
Show resolved
Hide resolved
<LivePreview | ||
scope={{ | ||
useComboboxPrimitive, | ||
useMultiSelectPrimitive, | ||
Box, | ||
Label, | ||
Input, | ||
useUID, | ||
useUIDSeed, | ||
ComboboxListbox, | ||
ComboboxListboxGroup, | ||
ComboboxListboxOption, | ||
FormPill, | ||
FormPillGroup, | ||
useFormPillState, | ||
}} | ||
noInline | ||
language="jsx" | ||
> | ||
{multiSelectExample} | ||
</LivePreview> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you could make this autocomplete, or put the chevron in the field?
Otherwise it looks like customer should be able to type in the field, but it doesn't allow for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm this is turning out to be way more scope than just Pill docs to get this to work. So two choices:
- example stays as is
- example is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing my "request changes" review to unblock, but left 2 new comments.
ok nvm this didn't remove my review.
6ac5274
to
80bf9ce
Compare