feat(modal): customization #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andioneto
added
the
Status: WIP
🦋 Changeset detectedLatest commit: 7b5dc97 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Status: Do Not Merge
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 5c72fd4 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/6157a102c11808000713fc6f 😎 Browse the preview: https://deploy-preview-1903--paste-theme-designer.netlify.app |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 5c72fd4 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/6157a1026c23c900077e2422 😎 Browse the preview: https://deploy-preview-1903--paste-docs.netlify.app |
|
Size Change: +316 B (0%) Total Size: 639 kB
ℹ️ View Unchanged
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7b5dc97:
|
nkrantz
reviewed
Oct 4, 2021
SiTaggart
reviewed
Oct 4, 2021
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 7b5dc97 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/615cb53fa312d10007df30f1 😎 Browse the preview: https://deploy-preview-1903--paste-theme-designer.netlify.app |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 7b5dc97 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/615cb53fe7b490000761f413 😎 Browse the preview: https://deploy-preview-1903--paste-docs.netlify.app |
SiTaggart
reviewed
Oct 4, 2021
andioneto
removed
the
Status: WIP
andioneto
commented
Oct 5, 2021
| }: {children: any; 'data-paste-element': string; style: any; className: string}, | ||
| ref: any | ||
| ) => ( | ||
| <div |
There was a problem hiding this comment.
Mocking the react portal for this test.
nkrantz
approved these changes
Oct 5, 2021
| const modalFooter = screen.getByTestId('modal-footer-test-id'); | ||
| expect(modalFooter.getAttribute('data-paste-element')).toEqual('MODAL_FOOTER'); | ||
|
|
||
| const modalFooterActions = modalFooter.firstChild as HTMLElement; |
There was a problem hiding this comment.
Is this different from using .firstElementChild?
andioneto
force-pushed
the
feat-modal-customization
branch
from
76c3c7d
to
f6e1281
Compare
SiTaggart
reviewed
Oct 5, 2021
| expect.extend(matchers); | ||
|
|
||
| jest.mock('@twilio-paste/modal-dialog-primitive', () => { | ||
| const actual = jest.requireActual('@twilio-paste/modal-dialog-primitive'); |
There was a problem hiding this comment.
I guess I'm a little unsure on why this needs to be mocked, so providing some sort of commentary on the why might be helpful in a code comment.
SiTaggart
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio