feat(popover): adding customization #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5e5fd1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Status: Do Not Merge
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 5e5fd1e 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/615f533af36def0008184127 😎 Browse the preview: https://deploy-preview-1915--paste-theme-designer.netlify.app |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 5e5fd1e 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/615f533a10de0e000767d375 😎 Browse the preview: https://deploy-preview-1915--paste-docs.netlify.app |
|
Size Change: +110 B (0%) Total Size: 654 kB
ℹ️ View Unchanged
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5e5fd1e:
|
TheSisb
approved these changes
Oct 6, 2021
| const popoverComp = screen.getByTestId('popover'); | ||
| const popoverButton = screen.getByTestId('popover-button'); | ||
|
|
||
| expect(popoverComp.querySelector('[data-paste-element="POPOVER"]')).toHaveStyleRule( |
There was a problem hiding this comment.
You might be able to just merge this it() block with the previous one, and check for the style and data-paste-element in the same block. Would simplify the test file by not needing the repetitive render boilerplate.
There was a problem hiding this comment.
Adding to this that could also create a wrapper component and pass it to the render function as a second arg:
{
wrapper: ({ children }) => (<SomeWrapper>{children}</SomeWrapper>)
}
zahnster
removed
the
Status: Do Not Merge
andioneto
approved these changes
Oct 6, 2021
| const popoverComp = screen.getByTestId('popover'); | ||
| const popoverButton = screen.getByTestId('popover-button'); | ||
|
|
||
| expect(popoverComp.querySelector('[data-paste-element="POPOVER"]')).toHaveStyleRule( |
There was a problem hiding this comment.
Adding to this that could also create a wrapper component and pass it to the render function as a second arg:
{
wrapper: ({ children }) => (<SomeWrapper>{children}</SomeWrapper>)
}
b24592e
to
5c400d1
Compare
zahnster
force-pushed
the
customization/popover
branch
from
5c400d1
to
5e5fd1e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds element customization to Popover, including stories and tests.
Customizable aspects: