chore(website): change page section link to icon #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a036c49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gloriliale
commented
Dec 2, 2021
gloriliale
commented
Dec 2, 2021
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: a036c49 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61d742f229316d0008ca197b 😎 Browse the preview: https://deploy-preview-2088--paste-docs.netlify.app |
|
Size Change: +12 B (0%) Total Size: 461 kB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a036c49:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 18871df 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/61d63b79ba82270008f7b8f3 😎 Browse the preview: https://deploy-preview-2088--paste-theme-designer.netlify.app |
shleewhite
reviewed
Dec 2, 2021
gloriliale
force-pushed
the
website/page-section-header
branch
from
28a8c16
to
1388066
Compare
loreina
approved these changes
Dec 3, 2021
|
This is looking great! Just a couple tiny design tweaks:
|
gloriliale
force-pushed
the
website/page-section-header
branch
from
1388066
to
0fe1c6c
Compare
github-actions
bot
added
the
Area: Components
SiTaggart
reviewed
Dec 17, 2021
packages/paste-website/stories/StyledAnchorHyperlink.stories.tsx
Outdated
Show resolved
Hide resolved
SiTaggart
reviewed
Dec 17, 2021
SiTaggart
reviewed
Dec 17, 2021
@katieporter done, done, and done! |
TheSisb
reviewed
Jan 4, 2022
gloriliale
force-pushed
the
website/page-section-header
branch
2 times, most recently
from
18871df
to
bd0571c
Compare
github-actions
bot
added
the
Type: Documentation
chore(heading): give display a default value
gloriliale
force-pushed
the
website/page-section-header
branch
from
bd0571c
to
7e7f3a6
Compare
shleewhite
approved these changes
Jan 6, 2022
gloriliale
force-pushed
the
website/page-section-header
branch
from
7e7f3a6
to
d619d6a
Compare
SiTaggart
approved these changes
Jan 6, 2022
chore(website): add hover state to link icon chore(website): add story, refactor to use Text chore(website): add marginBottom mapping chore(website): ensure heading text and icon align chore(website): fix story, props, slug and roadmap chore(website): update prop default value in table chore(website): remove comments chore(website): adjust design
gloriliale
force-pushed
the
website/page-section-header
branch
from
d619d6a
to
a036c49
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the link on the page section headers from the "#" character to the LinkIcon icon.