feat(popover): allow Badge as PopoverButton #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7e16d31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Area: Components
|
Size Change: +117 B (0%) Total Size: 461 kB
ℹ️ View Unchanged
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
shleewhite
force-pushed
the
feat/badge-popover
branch
from
1de2c72
to
9aca295
Compare
github-actions
bot
added
Area: Doc Site
|
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: 7e16d31 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/61b7e6776ddcdf0008f71da7 😎 Browse the preview: https://deploy-preview-2089--paste-theme-designer.netlify.app |
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: 7e16d31 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61b7e67723d162000751de26 😎 Browse the preview: https://deploy-preview-2089--paste-docs.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 979d04c:
|
github-actions
bot
added
Type: Tests
SiTaggart
reviewed
Dec 3, 2021
TheSisb
requested changes
Dec 3, 2021
SiTaggart
reviewed
Dec 13, 2021
shleewhite
force-pushed
the
feat/badge-popover
branch
from
27896e4
to
979d04c
Compare
SiTaggart
approved these changes
Dec 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
asprop, which defaults to'button'but can be set to'badge'. If set to'badge', PopoverButton renders a Badge.Also fixes bug where badge aggressively wraps contents when it is a link/button: https://issues.corp.twilio.com/browse/DSYS-3162
Contributing to Twilio