New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(badge): simplify children type #2156
Conversation
🦋 Changeset detectedLatest commit: eadf836 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for paste-theme-designer ready! 🔨 Explore the source changes: eadf836 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-theme-designer/deploys/61f4487a3142890e67f3c271 😎 Browse the preview: https://deploy-preview-2156--paste-theme-designer.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eadf836:
|
✔️ Deploy Preview for paste-docs ready! 🔨 Explore the source changes: eadf836 🔍 Inspect the deploy log: https://app.netlify.com/sites/paste-docs/deploys/61f4387b205c0000080b9e67 😎 Browse the preview: https://deploy-preview-2156--paste-docs.netlify.app |
Size Change: -22 B (0%) Total Size: 463 kB
ℹ️ View Unchanged
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍🏼
59e8e78
to
ec50b2a
Compare
…e into fix/badge-children-type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One potential change for the resize hook, otherwise lgtm!
children
prop toNonNullable<React.ReactNode>
Contributing to Twilio