chore(display-pill-group): update design for v2 #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TheSisb
commented
Jul 5, 2022
TheSisb
commented
- Upgrade DisplayPillGroup designs for v2.
- Clean up stories and examples on website.
🦋 Changeset detectedLatest commit: 3714e12 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
Status: Do Not Merge
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3714e12:
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
Size Change: -26 B (0%) Total Size: 596 kB
ℹ️ View Unchanged
|
TheSisb
force-pushed
the
display-pill-group/v2
branch
from
0ea079d
to
c2cc4fd
Compare
katieporter
reviewed
Jul 5, 2022
| @@ -48,10 +48,8 @@ export const DisplayPill = React.forwardRef<HTMLAnchorElement, DisplayPillProps> | |||
| _hover={{ | |||
| textDecoration: 'none', | |||
| }} | |||
| _focusVisible={{ | |||
| backgroundColor: 'colorBackgroundPrimaryWeakest', | |||
| _focus={{ | |||
There was a problem hiding this comment.
nitpick: can we remove the text-decoration on the focus state?
SiTaggart
approved these changes
Jul 5, 2022
TheSisb
force-pushed
the
display-pill-group/v2
branch
2 times, most recently
from
6567cf0
to
9ff25ff
Compare
katieporter
approved these changes
Jul 6, 2022
loreina
suggested changes
Jul 6, 2022
TheSisb
force-pushed
the
display-pill-group/v2
branch
from
21fe2f8
to
3714e12
Compare
loreina
approved these changes
Jul 7, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.