feat(avatar): add new variant and color props #2681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d33947c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d33947c:
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Size Change: +161 B (0%) Total Size: 818 kB
ℹ️ View Unchanged
|
TheSisb
previously approved these changes
Sep 19, 2022
nkrantz
previously approved these changes
Sep 19, 2022
SiTaggart
reviewed
Sep 20, 2022
| return ( | ||
| <Stack orientation="horizontal" spacing="space40"> | ||
| <Avatar shape="user" name="avatar example" icon={UserIcon} /> | ||
| <Avatar shape="entity" name="avatar example" icon={BusinessIcon} /> |
There was a problem hiding this comment.
suggestion: it might be a good addition to also have a User and Entity Image avatar to cover the shape when it's also an image background
There was a problem hiding this comment.
What would be an example of an entity image?
There was a problem hiding this comment.
For the purpose of VRT, any old image would be just fine. You can even just reuse one of the human images if you didn't want to source one.
SiTaggart
previously approved these changes
Sep 20, 2022
shleewhite
dismissed stale reviews from SiTaggart, nkrantz, and TheSisb
via
e239784
shleewhite
changed the title
SiTaggart
previously approved these changes
Sep 20, 2022
nkrantz
approved these changes
Sep 21, 2022
SiTaggart
approved these changes
Sep 21, 2022
kelseycavitt
approved these changes
Sep 21, 2022
shleewhite
added
the
🕵🏻♀️ Run website visual regression
Merged
andreasonny83
pushed a commit
to andreasonny83/paste
that referenced
this pull request
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Contributing to Twilio