chore(avatar): remove underline on avatars in anchors #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 893ddbf The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 893ddbf:
|
|
Size Change: +18 B (0%) Total Size: 747 kB
ℹ️ View Unchanged
|
gloriliale
previously approved these changes
Sep 22, 2022
| <DisplayPill href="/"> | ||
| <Avatar size="sizeIcon10" name="Avatar Anchor Example" /> | ||
| Bowling | ||
| </DisplayPill> |
There was a problem hiding this comment.
praise: thanks for including a story so we can ensure this doesn't break!
|
I just tried this on the deploy preview with Firefox and the letter seems misaligned vertically, can you reproduce this? |
nkrantz
added
🕵🏻♀️ Run website visual regression
TheSisb
approved these changes
Sep 23, 2022
serifluous
approved these changes
Sep 23, 2022
Merged
andreasonny83
pushed a commit
to andreasonny83/paste
that referenced
this pull request
Sep 28, 2022
* chore: remove underline on avatars in anchor * chore: snapshot * chore: fix vertical alignment of avatar stories * chore: delete commented code * chore: vertically align initials * chore: snapshot yet again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: DSYS-3449
This PR removes the extra underline from Avatars inside of Anchors or linked Display Pills.
Old:
Now:
