fix: add list style type to List component #2966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ab65e48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
3 tasks
github-actions
bot
added
the
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Niznikr
previously approved these changes
Jan 20, 2023
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Size Change: +41 B (0%) Total Size: 884 kB
ℹ️ View Unchanged
|
nkrantz
previously approved these changes
Jan 20, 2023
shleewhite
added
🕵🏻♀️ Run website visual regression
ghost
previously approved these changes
Jan 23, 2023
gloriliale
reviewed
Jan 23, 2023
gloriliale
reviewed
Jan 23, 2023
shleewhite
dismissed stale reviews from ghost
, nkrantz, and Niznikr
via
ab65e48
shleewhite
force-pushed
the
fix/list-style
branch
from
fd76d8d
to
ab65e48
Compare
Niznikr
approved these changes
Jan 23, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in this issue: #2954
Explicitly set the list style type on the list component so it doesn't get overriden.
Contributing to Twilio