feat(website): show text color token pairings #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca7f45e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5502 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ca7f45e:
|
|
Size Change: -105 B (0%) Total Size: 897 kB
ℹ️ View Unchanged
|
TheSisb
reviewed
Feb 21, 2023
...e-website/src/components/site-wrapper/sidebar/sidebar-disclosure/SidebarDisclosureButton.tsx
Outdated
Show resolved
Hide resolved
SiTaggart
force-pushed
the
feat/token-pairs
branch
from
6362461
to
6b66773
Compare
github-actions
bot
added
the
Area: Tokens
SiTaggart
force-pushed
the
feat/token-pairs
branch
from
3e33e80
to
ac7b454
Compare
SiTaggart
force-pushed
the
feat/token-pairs
branch
from
0f5279c
to
554f298
Compare
SiTaggart
commented
Feb 25, 2023
| color-text-decorative-40: | ||
| value: "{!palette-purple-60}" | ||
| comment: Text color with no semantic meaning, used for decorative purposes only. Should generally be used with matching decorative background and/or border tokens. | ||
| text_contrast_pairing: | ||
| - color-background | ||
| - color-background-body | ||
| - color-background-decorative-40 | ||
| - color-background-decorative-40-weakest |
There was a problem hiding this comment.
incorrect annotations here. These tokens don't exist.
SiTaggart
commented
Feb 25, 2023
| @@ -1,8 +1,8 @@ | |||
| imports: | |||
| - ../../../aliases/box-shadow.yml | |||
| - ../../../aliases/offset.yml | |||
There was a problem hiding this comment.
offset file was empty, might as well inherit the base
SiTaggart
commented
Feb 25, 2023
| @@ -155,31 +155,15 @@ props: | |||
| color-text-decorative-10: | |||
| value: "{!palette-gray-20}" | |||
| comment: Text color with no semantic meaning, used for decorative purposes only. Should generally be used with matching decorative background and/or border tokens. | |||
| text_contrast_pairing: | |||
There was a problem hiding this comment.
No need to declare the pairings at the theme level. The pairings are set at the system level, so every theme should meet the same token pair requirements as they are used in the same places across the theme.
SiTaggart
commented
Feb 25, 2023
| - ./color-palette.yml | ||
| - ./color.yml | ||
| - ./offset.yml |
There was a problem hiding this comment.
copy pasta from the other theme that didn't need the empty file
SiTaggart
commented
Feb 25, 2023
| @@ -3,7 +3,6 @@ global: | |||
| category: box-shadow | |||
| imports: | |||
| - ../../../global/box-shadow.yml | |||
| - ../aliases/box-shadow.yml | |||
SiTaggart
commented
Feb 25, 2023
| @@ -49,10 +49,6 @@ props: | |||
| color-text-decorative-30: | |||
| value: "{!palette-green-80}" | |||
| comment: Text color with no semantic meaning, used for decorative purposes only. Should generally be used with matching decorative background and/or border tokens. | |||
| text_contrast_pairing: | |||
TheSisb
previously approved these changes
Feb 27, 2023
serifluous
previously approved these changes
Feb 28, 2023
SiTaggart
added
🚀 merge it!
and removed
Status: Do Not Merge
shleewhite
previously approved these changes
Mar 1, 2023
| @@ -91,6 +91,7 @@ const Template: StoryFn<typeof TokenCard> = ({name, category, useCamelCase}) => | |||
| textColorInverse={textColorInverse} | |||
| borderColor={borderColor} | |||
| useCamelCase={useCamelCase} | |||
| text_contrast_pairing={text_contrast_pairing} | |||
There was a problem hiding this comment.
Question: why is this prop snake case? Could it be like the others?
There was a problem hiding this comment.
It totally could, essentially all this stuff is typed from the Tokens Object itself, and that's how it's named on the object, which is unfortunate. it's just lazy typing to be able to pass the object around without too much hassle and map the props to the object keys
nkrantz
approved these changes
Mar 2, 2023
SiTaggart
added
the
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Change One
Details of change...
Change Two
Details of change...
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel