fix: improved badge typing for prop combinations wrt button & a element types #3078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f7e6c28 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
3 tasks
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5599 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f7e6c28:
|
|
Size Change: -183 B (0%) Total Size: 975 kB
ℹ️ View Unchanged
|
| children: NonNullable<React.ReactNode>; | ||
| variant: BadgeVariants; | ||
| }; | ||
| export type BadgeSpanProps = React.HTMLAttributes<HTMLSpanElement> & { |
There was a problem hiding this comment.
Thanks for the improved typings
SiTaggart
commented
Mar 9, 2023
SiTaggart
force-pushed
the
fix/badge-combination-types
branch
from
51c2a21
to
220a0f7
Compare
nkrantz
approved these changes
Mar 14, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3070
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel