feat: ability to theme color-scheme #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 68ef033 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Theme
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
1 task
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 68ef033:
|
|
Size Change: +370 B (0%) Total Size: 976 kB
ℹ️ View Unchanged
|
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SiTaggart
force-pushed
the
fix/date-picker-icon-color-scheme
branch
from
4fc930a
to
270f1e3
Compare
github-actions
bot
added
Area: Components
Passing run #5698 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
loreina
approved these changes
Mar 29, 2023
TheSisb
approved these changes
Mar 29, 2023
| @@ -2,6 +2,7 @@ import {css} from '@twilio-paste/styling-library'; | |||
|
|
|||
| export const pasteBaseStyles = css({ | |||
| color: 'colorText', | |||
| colorScheme: 'colorScheme', | |||
nkrantz
approved these changes
Mar 29, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1609 and partially this #2708
Makes sure the date picker icons is visible in dark mode by switching the color-scheme at the theme level.
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel