feat: updated tab visual design #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8ce1b8c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ce1b8c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
Size Change: +223 B (0%) Total Size: 977 kB
ℹ️ View Unchanged
|
TheSisb
force-pushed
the
feat/tab-design-update
branch
from
0f36a66
to
22a447c
Compare
TheSisb
force-pushed
the
feat/tab-design-update
branch
from
a56d662
to
42de1f1
Compare
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8ce1b8c:
|
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Passing run #5772 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
serifluous
reviewed
Apr 5, 2023
serifluous
reviewed
Apr 5, 2023
github-actions
bot
added
the
Area: Tokens
|
I can't figure out where line height is defined, so I'm leaving this as a general comment here: Can you change the line height to line-height-30? It's ok if it changes vertical tabs, too. |
serifluous
reviewed
Apr 5, 2023
serifluous
reviewed
Apr 5, 2023
serifluous
reviewed
Apr 5, 2023
TheSisb
force-pushed
the
feat/tab-design-update
branch
from
37a498a
to
75ddd78
Compare
serifluous
previously approved these changes
Apr 6, 2023
TheSisb
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
serifluous
approved these changes
Apr 6, 2023
TheSisb
approved these changes
Apr 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Change One
Details of change...
Change Two
Details of change...
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel