feat(styling-library): expand types for cacheProvider #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c1491d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
TheSisb
commented
Apr 26, 2023
| @@ -43,6 +43,7 @@ | |||
| "react": "^18.0.0", | |||
| "react-dom": "^18.0.0", | |||
| "react-helmet": "^6.1.0", | |||
| "react-shadow": "^20.0.0", | |||
There was a problem hiding this comment.
dev-dependency on this package because we only use it for the story
| @@ -17,11 +16,11 @@ export type { | |||
| EmotionLabel, | |||
| CSSObject, | |||
| } from '@styled-system/css'; | |||
| export type {Options as CreateCacheOptions} from '@emotion/cache'; | |||
There was a problem hiding this comment.
Just re-export the whole thing, no point limiting it anymore
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@twilio-paste/styling-library': patch | |||
| '@twilio-paste/core': patch | |||
There was a problem hiding this comment.
patch change because this is unsupported, undocumented changes
| title: 'Theme/ThemeProvider/CacheProvider', | ||
| }; | ||
|
|
||
| export const CacheProviderContainer = (): React.ReactNode => { |
There was a problem hiding this comment.
Added a quick example to demonstrate it working
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4c1491d:
|
Passing run #5896 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Size Change: 0 B Total Size: 979 kB ℹ️ View Unchanged
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4c1491d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
TheSisb
force-pushed
the
emotion-cache-provider-types
branch
from
575dd44
to
1aa6283
Compare
SiTaggart
previously approved these changes
Apr 26, 2023
TheSisb
force-pushed
the
emotion-cache-provider-types
branch
from
91220f7
to
4c1491d
Compare
SiTaggart
approved these changes
Apr 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands types on
@twilio-paste/styling-library, and in turn@twilio-paste/themfor cacheProviderProps such that acontainerkey may be passed so Emotion styles can be injected within certain elements, like in shadow-dom.Resolves #3196