docs(website): add Sidebar docs and fix minor component types #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0167b5b The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0167b5b:
|
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +211 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
Passing run #6166 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0167b5b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
should we change this from alpha to prod status re: this comment |
|
@nkrantz Not yet, until navigation is in it's still alpha. In my nav branch I've already changed some fundamental things, like making the sidebar component display flex and direction vertical |
nkrantz
previously approved these changes
May 9, 2023
|
Not sure if this was an issue before, but on collapse Flex story I'm seeing icons getting cropped |
nkrantz
reviewed
Jun 22, 2023
|
todo: adjust shadow on scroll to be a bit more subtle: https://www.figma.com/file/8v0hGUOcPje1Gu0RExa9Cx/Untitled?type=design&node-id=1-14802&mode=design&t=tBAxV0ZCdEXhwlJ1-4 |
serifluous
requested changes
Jun 27, 2023
packages/paste-core/components/sidebar/stories/full-composition/console.stories.tsx
Show resolved
Hide resolved
serifluous
previously approved these changes
Jun 28, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of adding the docs, I made a few small fixes to the components as I noticed them.