feat(avatar): add avatar group #3218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d2b0ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7d2b0ee. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d2b0ee:
|
Passing run #5986 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Size Change: +327 B (0%) Total Size: 983 kB
ℹ️ View Unchanged
|
nkrantz
force-pushed
the
avatar-group
branch
3 times, most recently
from
31fd84e
to
05142ee
Compare
github-actions
bot
added
Area: Doc Site
nkrantz
force-pushed
the
avatar-group
branch
2 times, most recently
from
d4405f9
to
f9fc925
Compare
github-actions
bot
added
the
Area: Tokens
SiTaggart
reviewed
May 10, 2023
| expect(getGroupSpacing('sizeIcon30', 'entity')).toEqual('spaceNegative10'); | ||
| expect(getGroupSpacing('sizeIcon100', 'entity')).toEqual('spaceNegative20'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
praise: nice to see tests!
SiTaggart
reviewed
May 10, 2023
SiTaggart
reviewed
May 10, 2023
| <Avatar size="sizeIcon80" name="Twilio Flex" variant="entity" icon={ProductFlexIcon} /> | ||
| <Avatar size="sizeIcon90" name="Twilio Voice" variant="entity" icon={ProductVoiceIcon} /> | ||
| <Avatar size="sizeIcon100" name="Twilio Studio" variant="entity" icon={ProductStudioIcon} /> | ||
| <Avatar size="sizeIcon110" name="Twilio Interconnect" variant="entity" icon={ProductInterconnectIcon} /> |
There was a problem hiding this comment.
praise: loving these new examples
SiTaggart
reviewed
May 10, 2023
|
|
||
| ### Accessibility | ||
|
|
||
| The `name` prop is required on all instances of the Avatar component. This ensures that whether your Avatar is displaying initials, an image, or an icon, the user will be able to access information about what object is being represented by the Avatar. The full string passed to `name` appears as a title upon hovering the Avatar, and is useful to assistive technology users. |
TheSisb
reviewed
May 11, 2023
|
|
||
| ### Accessibility | ||
|
|
||
| The `name` prop is required on all instances of the Avatar component. This ensures that whether your Avatar is displaying initials, an image, or an icon, the user will be able to access information about what object is being represented by the Avatar. The full string passed to `name` appears as a title upon hovering the Avatar, and is useful to assistive technology users. |
SiTaggart
approved these changes
May 11, 2023
loreina
approved these changes
May 11, 2023
loreina
approved these changes
May 11, 2023
nkrantz
added
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Avatar Group component to
@twilio-paste/avatar