feat(user-dialog): add user dialog listbox #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: ce5b0e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ce5b0e1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ce5b0e1:
|
Passing run #6132 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Size Change: -1.15 kB (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
nkrantz
force-pushed
the
user-dialog-part-II
branch
from
11a891b
to
d957205
Compare
TheSisb
reviewed
Jun 22, 2023
| UserDialogListboxItem.displayName = 'UserDialogListboxItem'; | ||
|
|
||
| export const UserDialogListItem = React.forwardRef<HTMLButtonElement, UserDialogListItemProps>( | ||
| ({children, element = 'USER_DIALOG', ...props}, ref) => { |
There was a problem hiding this comment.
question: should we / can we provide a aria-selected state to an item at mount? So like, when you first open the dialog it's properly labeled on which item is currently selected, if any
There was a problem hiding this comment.
are you suggesting automatically selecting one of the items upon opening the dialog?
aria-selected is automatically set on the listbox item already
There was a problem hiding this comment.
It sets it automatically to the current selected value, even if it isnt the first item? If so, then good!
There was a problem hiding this comment.
oh are you suggesting an aria state on the listbox or on the list item? on the list item it's aria-selected="true" but the selected item isn't represented on the listbox itself
packages/paste-core/components/topbar/stories/userDialog.stories.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/components/topbar/stories/userDialog.stories.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/primitives/listbox/src/ListboxPrimitive.tsx
Outdated
Show resolved
Hide resolved
packages/paste-core/components/topbar/src/user-dialog/UserDialog.tsx
Outdated
Show resolved
Hide resolved
nkrantz
force-pushed
the
user-dialog-part-II
branch
from
ecd77b1
to
f6433ce
Compare
nkrantz
force-pushed
the
user-dialog-part-II
branch
from
b39dc8d
to
fe2add1
Compare
TheSisb
reviewed
Jun 27, 2023
packages/paste-core/components/user-dialog/stories/index.stories.tsx
Outdated
Show resolved
Hide resolved
TheSisb
previously approved these changes
Jun 27, 2023
nkrantz
force-pushed
the
user-dialog-part-II
branch
from
16d8ab4
to
1b80cb7
Compare
nkrantz
changed the title
SiTaggart
added
🕵🏻♀️ Run website visual regression
loreina
previously approved these changes
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio