feat(slider): add new component #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: bea95d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
TheSisb
force-pushed
the
slider/add-package
branch
from
7be3474
to
6b13270
Compare
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit bea95d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TheSisb
force-pushed
the
slider/add-package
branch
from
6b13270
to
4057b25
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b13270:
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit bea95d6:
|
|
Size Change: +238 B (0%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
1 failed tests on run #6485 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Full Site VRT Batch 2 > should vrt /components/editable-code-block/ |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
SiTaggart
reviewed
Aug 4, 2023
| /** | ||
| * Used to adjust how the numbers are rendered and interpreted. | ||
| * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat \ | ||
| */ |
There was a problem hiding this comment.
praise: useful TSDoc comments
SiTaggart
reviewed
Aug 4, 2023
SiTaggart
reviewed
Aug 4, 2023
SiTaggart
reviewed
Aug 4, 2023
SiTaggart
reviewed
Aug 4, 2023
SiTaggart
reviewed
Aug 4, 2023
SiTaggart
reviewed
Aug 4, 2023
serifluous
reviewed
Aug 4, 2023
serifluous
reviewed
Aug 4, 2023
packages/paste-core/components/slider/stories/index.stories.tsx
Outdated
Show resolved
Hide resolved
TheSisb
force-pushed
the
slider/add-package
branch
from
955a3dd
to
3334e66
Compare
nkrantz
reviewed
Aug 7, 2023
| }); | ||
| }); | ||
|
|
||
| describe('Customization', () => { |
There was a problem hiding this comment.
suggestion: tests for applying custom styles?
There was a problem hiding this comment.
Those are handled by Chromatic. I realize we duplicate a lot of effort everywhere, figured I'd break the trend.
TheSisb
force-pushed
the
slider/add-package
branch
from
3334e66
to
1811656
Compare
SiTaggart
previously approved these changes
Aug 7, 2023
serifluous
reviewed
Aug 7, 2023
serifluous
reviewed
Aug 7, 2023
serifluous
approved these changes
Aug 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new Slider package based on React-Spectrum's headless UI hooks.
Spec document