docs(website): add Slider documentation #3384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: cab61be The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit cab61be. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cab61be:
|
|
Size Change: -3 B (0%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
TheSisb
force-pushed
the
slider/add-package
branch
2 times, most recently
from
3334e66
to
1811656
Compare
TheSisb
force-pushed
the
slider/add-docs
branch
from
9389ccd
to
44a2d7e
Compare
github-actions
bot
removed
the
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #6500 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
loreina
reviewed
Aug 9, 2023
Comment on lines
+131
to
+135
| <LivePreview scope={{Form, FormControl, Label, Slider, HelpText, useUID}} language="jsx" noInline> | ||
| {errorSlider} | ||
| </LivePreview> |
There was a problem hiding this comment.
issue(blocking): use disabled Label
issue(non-blocking): it looks like the min/max values are using color-text-weak instead of color-text-weaker. was this intentional or did we perhaps miss this in the component review? cc @serifluous
There was a problem hiding this comment.
Figma is using weak, not weaker
TheSisb
force-pushed
the
slider/add-docs
branch
from
d311c5a
to
958a4cf
Compare
github-actions
bot
added
the
Area: Components
serifluous
reviewed
Aug 9, 2023
serifluous
approved these changes
Aug 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the docs for the new Slider component.