fix: try fix our requireJS clash with building for the node platform and not browser #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 868d7b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 110 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Infrastructure
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 868d7b4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 868d7b4:
|
|
Size Change: -24.5 kB (-2%) Total Size: 992 kB
ℹ️ View Unchanged
|
Passing run #6515 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
SiTaggart
commented
Aug 9, 2023
| @@ -24,7 +24,7 @@ | |||
| "tsc": "tsc" | |||
| }, | |||
| "dependencies": { | |||
| "react-uid": "2.3.1" | |||
| "react-uid": "2.3.3" | |||
There was a problem hiding this comment.
removes tslib as a dependency.
SiTaggart
commented
Aug 9, 2023
| @@ -214,7 +214,8 @@ | |||
| }, | |||
| "resolutions": { | |||
| "csstype": "3.0.11", | |||
| "playwright": "1.28.1" | |||
| "playwright": "1.28.1", | |||
| "tslib": "2.6.1" | |||
There was a problem hiding this comment.
removes all the different versions
SiTaggart
force-pushed
the
chore/tslib-dep
branch
from
38280e9
to
b34e8e4
Compare
github-actions
bot
added
Type: Documentation
SiTaggart
added
the
🕵🏻♀️ Run website visual regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Change Platform target to browser
We currently target node as the platform. That has some consequences with the way esbuild handles conditions and the way it handles export maps.
What seems to be happening is that when it targets node, a packages export map may list a
modulepath, but esbuild ignores it and just grabs the default or import. Depending on the way the library is built that means an es modules build of our ackage will grab and bundle a commonJS or UMD version of the library and not the es module version.Switching the platform to
browsermeans it will respect the export map and grab the actual es module version of any dependencies.Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel