chore: fix reset button types #3454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
🦋 Changeset detectedLatest commit: 272e7b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 272e7b0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: 0 B Total Size: 1.01 MB ℹ️ View Unchanged
|
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 272e7b0:
|
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Passing run #6693 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
TheSisb
previously approved these changes
Aug 30, 2023
.changeset/brave-gorillas-begin.md
Outdated
| '@twilio-paste/core': patch | ||
| --- | ||
|
|
||
| Removal of ts annotation to expect an error for reset button style overrides |
There was a problem hiding this comment.
Suggested change
| Removal of ts annotation to expect an error for reset button style overrides | |
| [User Dialog] Removal of ts annotation to expect an error for reset button style overrides |
There was a problem hiding this comment.
Although I wonder if we even need to ship this as a patch since it doesn't affect users really?
There was a problem hiding this comment.
Probably not, it's just to appease the Danger JS check
TheSisb
reviewed
Aug 30, 2023
| variant?: 'reset'; | ||
| }; | ||
|
|
||
| export type ButtonProps = (BaseVariantsButtonProps | ResetVariantButtonProps) & |
There was a problem hiding this comment.
Do we want to add docs for this? An example of using reset button? Or keep it under wraps for now?
There was a problem hiding this comment.
Keep it under wraps for now
nkrantz
previously approved these changes
Aug 30, 2023
There was a problem hiding this comment.
suggestion(non-blocking): can you add to the docs example explaining that our tokens can be used to style reset buttons?
nkrantz
approved these changes
Aug 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Fix the reset variant button types
Conditionally allow style props on a reset button variant
Improve button types
ButtonProps didn't extend DirectButtonProps. This led to a mismatch between the consumer types and the internal types. For example, to a consumer we didn't restrict tabIndex to 0 and -1 but we did internally.
Iput and User Dialog removal of ts expect error
No longer needed for the reset button as style props are valid.
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel