chore(meter): add docs, update designs #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 00db38c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 00db38c:
|
|
Size Change: +217 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 00db38c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
nkrantz
force-pushed
the
meter-designs
branch
from
21a8da9
to
59a6c3c
Compare
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #6764 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
nkrantz
force-pushed
the
meter-designs
branch
from
59a6c3c
to
ada46e7
Compare
nkrantz
force-pushed
the
meter-designs
branch
from
ada46e7
to
5e905bb
Compare
TheSisb
reviewed
Sep 6, 2023
nkrantz
force-pushed
the
meter-designs
branch
3 times, most recently
from
06ee11f
to
b122859
Compare
TheSisb
reviewed
Sep 7, 2023
| value?: number; | ||
| id: string; | ||
| showValueLabel?: boolean; |
There was a problem hiding this comment.
question: this is a breaking api change. Are we comfortable marking these changes as a patch when the package is on 1.0.0?
I think it's fine, since the docs aren't even out. But just wanted to call it out
There was a problem hiding this comment.
good point, I agree that it's fine since nobody's using it and it is an alpha component
nkrantz
force-pushed
the
meter-designs
branch
from
b122859
to
6a7ed21
Compare
serifluous
reviewed
Sep 7, 2023
serifluous
reviewed
Sep 7, 2023
serifluous
reviewed
Sep 7, 2023
serifluous
reviewed
Sep 7, 2023
serifluous
reviewed
Sep 7, 2023
serifluous
reviewed
Sep 7, 2023
serifluous
reviewed
Sep 7, 2023
ceyerkes
previously approved these changes
Sep 7, 2023
nkrantz
force-pushed
the
meter-designs
branch
from
6a7ed21
to
a215ffe
Compare
nkrantz
added
🕵🏻♀️ Run website visual regression
TheSisb
previously approved these changes
Sep 7, 2023
serifluous
reviewed
Sep 7, 2023
nkrantz
force-pushed
the
meter-designs
branch
from
a215ffe
to
00db38c
Compare
serifluous
approved these changes
Sep 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
Meter API
Design and API are as closely aligned as possible. Any aria values present in the DOM can be displayed on the Meter. The value label is set on the MeterLabel component using the
valueLabelprop. Min and max value labels are optional and set on the Meter usingminLabelandmaxLabelprops. This allows the consumer to have full control, using a string rather than a number.