chore: components d to h type docs #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 7891a3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
SiTaggart
force-pushed
the
chore/component-types-d-h
branch
from
2c4bc15
to
c0d1b34
Compare
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7891a3e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7891a3e:
|
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #6918 ↗︎
Details:
Review all test suite changes for PR #3502 ↗︎ |
|||||||||||||||
SiTaggart
force-pushed
the
chore/component-types-d-h
branch
from
c0d1b34
to
168860a
Compare
github-actions
bot
added
the
Area: Infrastructure
|
Size Change: -41 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
nkrantz
reviewed
Sep 28, 2023
serifluous
reviewed
Sep 29, 2023
serifluous
reviewed
Sep 29, 2023
There was a problem hiding this comment.
todo: Hide "inherited props" disclosure if nothing's in it, like DataGridRow
There was a problem hiding this comment.
I suggested the same thing but as simon pointed out, all documented components that are used by consumers should have inherited props. aka this is a types fix that needs to be made on DataGridRow
SiTaggart
force-pushed
the
chore/component-types-d-h
branch
from
7ee417b
to
02de806
Compare
SiTaggart
force-pushed
the
chore/component-types-d-h
branch
from
bcfbfad
to
822d30b
Compare
nkrantz
previously approved these changes
Oct 3, 2023
SiTaggart
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
nkrantz
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Changes in this PR:
Change One
Details of change...
Change Two
Details of change...
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel