feat(progress-bar): add new props and refine styles #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 4f2e789 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
TheSisb
force-pushed
the
progress-bar/refine
branch
from
4ea5e13
to
8be57df
Compare
github-actions
bot
added
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4f2e789. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4f2e789:
|
1 flaky test on run #6998 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Token list filter format control and theme control > controls the theme of filtered tokens |
Output
Screenshots
|
|
Review all test suite changes for PR #3549 ↗︎
|
Size Change: +115 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
serifluous
previously approved these changes
Oct 13, 2023
nkrantz
reviewed
Oct 16, 2023
nkrantz
reviewed
Oct 16, 2023
There was a problem hiding this comment.
just the changelog typo.
non-blocking because sarah already approved, but it's really hard for me to tell that the indeterminate story is doing anything. It's hard to see the skeleton loader on that small of a space and feels like the animation is moving too slowly to notice it
|
Yea, I agree about indeterminate. Looks like Sarah has plans to fast-follow with a fix. |
TheSisb
force-pushed
the
progress-bar/refine
branch
from
8be57df
to
4f2e789
Compare
nkrantz
approved these changes
Oct 16, 2023
TheSisb
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ProgressBar] Added new features and updated the design.
The ProgressBarLabel component has the following new props:
valueLabelwhich displays a plain text value on the right side of the label.disabledwhich applies disabled styling on the label.The ProgressBar component has updated styling and the following new props:
hasErrorwhich displays error styling.disabledwhich displays disabled styling.