chore: component types i-p #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 84645dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
packages/paste-website/src/pages/components/product-switcher/api.mdx
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 84645dd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84645dd:
|
Passing run #7027 ↗︎
Details:
Review all test suite changes for PR #3557 ↗︎ |
|||||||||||||||
|
Size Change: -93 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
nkrantz
force-pushed
the
component-types-i-p
branch
2 times, most recently
from
f310b08
to
88b525d
Compare
SiTaggart
reviewed
Oct 18, 2023
| * | ||
| * @type {BoxStyleProps["paddingRight"]} | ||
| * @memberof InputProps | ||
| */ | ||
| paddingRight?: BoxStyleProps["paddingRight"]; |
There was a problem hiding this comment.
Wooooow, why would we even do this? 🤔
SiTaggart
reviewed
Oct 18, 2023
SiTaggart
reviewed
Oct 18, 2023
SiTaggart
reviewed
Oct 18, 2023
packages/paste-core/components/minimizable-dialog/src/index.tsx
Outdated
Show resolved
Hide resolved
SiTaggart
reviewed
Oct 18, 2023
| type MenuInitialStateProps = MenuInitialState; | ||
| type MenuStateReturnProps = MenuStateReturn; | ||
|
|
||
| export type { MenuInitialStateProps, MenuStateReturnProps }; |
There was a problem hiding this comment.
praise: I kinda liked how some of these packages with hooks seemed to follow a pattern of hook docs first followed by components. Was that intentional?
There was a problem hiding this comment.
just following the pattern from your first types PR of keeping them at the top of the file
nkrantz
force-pushed
the
component-types-i-p
branch
from
a6084d9
to
84645dd
Compare
nkrantz
added
🕵🏻♀️ Run website visual regression
SiTaggart
approved these changes
Oct 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Note: ** ProgressBar docs not included in this PR because Shadi is working on them currently