chore(tabs, in page nav): update styles #3579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 919f6bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 919f6bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 919f6bb:
|
Passing run #7083 ↗︎
Details:
Review all test suite changes for PR #3579 ↗︎ |
|||||||||||||||
|
Size Change: +1.04 kB (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
SiTaggart
reviewed
Oct 25, 2023
| @@ -96,6 +123,13 @@ export interface InPageNavigationItemProps extends HTMLPasteProps<"a"> { | |||
| * @memberof InPageNavigationItemProps | |||
| */ | |||
| href: string; | |||
| /** | |||
| * Accessible title for when the InPageNavigationItem is truncated. Usage is strongly recommended on all InPageNavigationItems, but especially when the text might be truncated (in vertical InPageNavigations or horizontal ones with more than 3 items). | |||
There was a problem hiding this comment.
praise: loving our ability to write better api docs
SiTaggart
reviewed
Oct 25, 2023
SiTaggart
reviewed
Oct 25, 2023
| @@ -68,6 +68,8 @@ module.exports = { | |||
| "_selected_hover", | |||
| "_selected_focus", | |||
| "_selected_focusVisible", | |||
| "_selected_after", | |||
| "_focus_selected_after", | |||
There was a problem hiding this comment.
observation: weird that you added four, but eslint only cared about two of them
There was a problem hiding this comment.
yeah that's why the error was throwing me off
nkrantz
force-pushed
the
in-page-nav-tabs
branch
from
33636c3
to
a3be356
Compare
SiTaggart
previously approved these changes
Oct 26, 2023
nkrantz
commented
Oct 27, 2023
nkrantz
commented
Oct 27, 2023
serifluous
reviewed
Oct 27, 2023
serifluous
reviewed
Oct 27, 2023
serifluous
reviewed
Oct 27, 2023
serifluous
reviewed
Oct 27, 2023
nkrantz
force-pushed
the
in-page-nav-tabs
branch
from
a3be356
to
09f95d6
Compare
SiTaggart
previously approved these changes
Oct 30, 2023
nkrantz
force-pushed
the
in-page-nav-tabs
branch
from
9fb9a27
to
603bf2e
Compare
nkrantz
force-pushed
the
in-page-nav-tabs
branch
from
603bf2e
to
919f6bb
Compare
SiTaggart
approved these changes
Oct 31, 2023
nkrantz
added
🕵🏻♀️ Run website visual regression
serifluous
approved these changes
Oct 31, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Page Nav
Tabs
full_widthandinverse_full_widthvariants (same as fitted)Tokens
Box