fix: allow for scrolling long menus #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
dosubot
bot
added
the
size:S
🦋 Changeset detectedLatest commit: eb215dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "@twilio-paste/core": patch | ||
| --- | ||
|
|
||
| [Menu]: Adds overflow scrolling behaviour on menus with a large number of items in, currently defaulting to 10 items |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"behaviour" is a misspelling of "behavior"
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit eb215dd:
|
|
Size Change: +22 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
Passing run #7434 ↗︎
Details:
Review all test suite changes for PR #3709 ↗︎ |
|||||||||||||||
nkrantz
approved these changes
Jan 9, 2024
nkrantz
added
🕵🏻♀️ Run website visual regression
Passing run #7437 ↗︎
Details:
Review all test suite changes for PR #3709 ↗︎ |
|||||||||||||||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and useful links to discussions / issues / tickets
Allows for scrolling menus
Add overflow and max height to the menu
To address #3629 add vertical scrolling and a max height of roughly 10 items to follow other components such as Combobox
Checklist
requiredchecks have passed🕵🏻♀️ Run website visual regressionlabel