feat: add brand badges #3798
Merged
feat: add brand badges #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: f9b1149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f9b1149. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
Size Change: +1.09 kB (0%) Total Size: 1.02 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f9b1149:
|
nkrantz
force-pushed
the
brand-badges
branch
from
fbe2977
to
149f15b
Compare
Passing run #7873 ↗︎
Details:
Review all test suite changes for PR #3798 ↗︎ |
|||||||||||||||
dosubot
bot
added
the
size:XXL
serifluous
requested changes
Mar 5, 2024
TheSisb
reviewed
Mar 6, 2024
| @@ -78,6 +78,21 @@ export const badgeVariantStyles: { | |||
| color: "colorTextDecorative40", | |||
| boxShadow: "shadowBorderDecorative40Weaker", | |||
| }, | |||
| brand10: { | |||
There was a problem hiding this comment.
question: Why are using brand10/20/30 instead of brandTwilio/Segment/Sendgrid? I don't think we will ever have brands in between Twilio and SendGrid, so we don't need the 10gap to fill in missed values. Each brand is unique and probably doesn't need to be guessable, since they are known entities.
There was a problem hiding this comment.
Another thought:
This may be more clear as brandConsole/Segment/SendGrid so people don't just use them as new color options, but instead as semantically necessary to illustrate a brand color. It would be unideal if they were used a brand colors and Console made heavy use of Segment's brand color.
There was a problem hiding this comment.
The brand team wants to move away from having brand colors map to specific products, which makes sense since Email is going to be moved into Console soon. The brand10/20/30 naming makes it a little more flexible to whatever happens when the products are more unified.
See this example on twilio.com. Blue is used for Flex:
TheSisb
approved these changes
Mar 6, 2024
serifluous
approved these changes
Mar 6, 2024
nkrantz
added
🕵🏻♀️ Run website visual regression
Passing run #7874 ↗︎
Details:
Review all test suite changes for PR #3798 ↗︎ |
|||||||||||||||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on adding new badge variants and related design tokens to the Twilio Paste design system. The new badge variants are
brand10,brand20, andbrand30, and the new design tokens are shadow border tokens for these new badge variants.Here are the most significant changes:
New Badge Variants:
packages/paste-core/components/badge/src/constants.ts: Addedbrand10,brand20, andbrand30to theBadgeVariantsconstant.packages/paste-core/components/badge/src/styles.ts: Added styles for the new badge variants inbadgeVariantStylesandbadgeButtonStyles. [1] [2]packages/paste-core/components/badge/stories/index.stories.tsx: Added examples of the new badge variants in theAllBadges,SmallBadges,Brand10Badge,Brand20Badge, andBrand30Badgecomponents. [1] [2] [3]New Design Tokens:
.changeset/bright-steaks-rhyme.md&.changeset/soft-files-film.md: Added new design tokens for the new badge variants. [1] [2]packages/paste-design-tokens/__tests__/__snapshots__/index.test.tsx.snap: Updated snapshots to reflect the new design tokens. [1] [2] [3] [4] [5]Type Updates:
packages/paste-core/components/badge/type-docs.json,packages/paste-core/components/menu/type-docs.json,packages/paste-core/components/popover/type-docs.json,packages/paste-core/primitives/box/type-docs.json,packages/paste-core/primitives/sibling-box/type-docs.json,packages/paste-core/primitives/text/type-docs.json: Updated thevarianttype to include the new badge variants. [1] [2] [3] [4] [5] [6]Other Changes:
packages/paste-core/components/badge/stories/index.stories.tsx: Imported new icons to be used in the badge examples.