Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(menu): updated font color, width, and zindex styles #545

Merged
merged 2 commits into from Jul 1, 2020

Conversation

TheSisb
Copy link
Collaborator

@TheSisb TheSisb commented Jul 1, 2020

Updates:

  • Changed default fontColor for menuitem to colorText from colorTextLink
  • Updated minWidth to the smallest token (sketch had a smaller value :/)
  • Updated zIndex to the 20 value. For any overlay type component I think 20 is a safer default value because developer code can occasionally use zIndex10.

@vercel
Copy link

vercel bot commented Jul 1, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/twilio-dsys/paste/lb845whqg
✅ Preview: https://paste-git-menu-style-tweaks.twilio-dsys.vercel.app

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2020

Size Change: 0 B

Total Size: 394 kB

Filename Size Change
packages/paste-core/components/menu/dist/index.js 1.69 kB -1 B
packages/paste-core/core-bundle/dist/index.es.js 37.2 kB +1 B
ℹ️ View Unchanged
Filename Size Change
packages/paste-core/components/alert/dist/index.es.js 2.76 kB 0 B
packages/paste-core/components/alert/dist/index.js 2.34 kB 0 B
packages/paste-core/components/anchor/dist/index.es.js 1.04 kB 0 B
packages/paste-core/components/anchor/dist/index.js 646 B 0 B
packages/paste-core/components/button/dist/index.es.js 3.89 kB 0 B
packages/paste-core/components/button/dist/index.js 3.5 kB 0 B
packages/paste-core/components/card/dist/index.es.js 1.1 kB 0 B
packages/paste-core/components/card/dist/index.js 715 B 0 B
packages/paste-core/components/combobox/dist/index.es.js 2.58 kB 0 B
packages/paste-core/components/combobox/dist/index.js 2.18 kB 0 B
packages/paste-core/components/form/dist/index.es.js 8.47 kB 0 B
packages/paste-core/components/form/dist/index.js 8.08 kB 0 B
packages/paste-core/components/heading/dist/index.es.js 1.21 kB 0 B
packages/paste-core/components/heading/dist/index.js 817 B 0 B
packages/paste-core/components/list/dist/index.es.js 1.16 kB 0 B
packages/paste-core/components/list/dist/index.js 765 B 0 B
packages/paste-core/components/menu/dist/index.es.js 2.09 kB 0 B
packages/paste-core/components/modal/dist/index.es.js 2.9 kB 0 B
packages/paste-core/components/modal/dist/index.js 2.48 kB 0 B
packages/paste-core/components/paragraph/dist/index.es.js 237 B 0 B
packages/paste-core/components/paragraph/dist/index.js 278 B 0 B
packages/paste-core/components/popover/dist/index.es.js 2.16 kB 0 B
packages/paste-core/components/popover/dist/index.js 1.76 kB 0 B
packages/paste-core/components/screen-reader-only/dist/index.es.js 711 B 0 B
packages/paste-core/components/screen-reader-only/dist/index.js 322 B 0 B
packages/paste-core/components/separator/dist/index.es.js 1.12 kB 0 B
packages/paste-core/components/separator/dist/index.js 732 B 0 B
packages/paste-core/components/spinner/dist/index.es.js 1.8 kB 0 B
packages/paste-core/components/spinner/dist/index.js 1.35 kB 0 B
packages/paste-core/components/tabs/dist/index.es.js 1.85 kB 0 B
packages/paste-core/components/tabs/dist/index.js 1.42 kB 0 B
packages/paste-core/components/truncate/dist/index.es.js 666 B 0 B
packages/paste-core/components/truncate/dist/index.js 279 B 0 B
packages/paste-core/components/typography/dist/index.es.js 1.54 kB 0 B
packages/paste-core/components/typography/dist/index.js 1.56 kB 0 B
packages/paste-core/core-bundle/dist/index.js 37.5 kB 0 B
packages/paste-core/layout/absolute/dist/index.es.js 470 B 0 B
packages/paste-core/layout/absolute/dist/index.js 492 B 0 B
packages/paste-core/layout/aspect-ratio/dist/index.es.js 1.03 kB 0 B
packages/paste-core/layout/aspect-ratio/dist/index.js 628 B 0 B
packages/paste-core/layout/flex/dist/index.es.js 1.81 kB 0 B
packages/paste-core/layout/flex/dist/index.js 1.4 kB 0 B
packages/paste-core/layout/grid/dist/index.es.js 1.64 kB 0 B
packages/paste-core/layout/grid/dist/index.js 1.2 kB 0 B
packages/paste-core/layout/media-object/dist/index.es.js 508 B 0 B
packages/paste-core/layout/media-object/dist/index.js 544 B 0 B
packages/paste-core/layout/stack/dist/index.es.js 1.31 kB 0 B
packages/paste-core/layout/stack/dist/index.js 912 B 0 B
packages/paste-core/primitives/box/dist/index.es.js 2.15 kB 0 B
packages/paste-core/primitives/box/dist/index.js 2.13 kB 0 B
packages/paste-core/primitives/combobox/dist/index.es.js 105 B 0 B
packages/paste-core/primitives/combobox/dist/index.js 224 B 0 B
packages/paste-core/primitives/disclosure/dist/index.es.js 120 B 0 B
packages/paste-core/primitives/disclosure/dist/index.js 208 B 0 B
packages/paste-core/primitives/menu/dist/index.es.js 165 B 0 B
packages/paste-core/primitives/menu/dist/index.js 260 B 0 B
packages/paste-core/primitives/modal-dialog/dist/index.es.js 14.2 kB 0 B
packages/paste-core/primitives/modal-dialog/dist/index.js 14.2 kB 0 B
packages/paste-core/primitives/non-modal-dialog/dist/index.es.js 141 B 0 B
packages/paste-core/primitives/non-modal-dialog/dist/index.js 228 B 0 B
packages/paste-core/primitives/tabs/dist/index.es.js 121 B 0 B
packages/paste-core/primitives/tabs/dist/index.js 211 B 0 B
packages/paste-core/primitives/text/dist/index.es.js 1.63 kB 0 B
packages/paste-core/primitives/text/dist/index.js 1.62 kB 0 B
packages/paste-core/primitives/tooltip/dist/index.es.js 129 B 0 B
packages/paste-core/primitives/tooltip/dist/index.js 218 B 0 B
packages/paste-design-tokens/dist/tokens.common.js 2.42 kB 0 B
packages/paste-design-tokens/dist/tokens.es6.js 2.38 kB 0 B
packages/paste-libraries/animation/dist/index.es.js 16.7 kB 0 B
packages/paste-libraries/animation/dist/index.js 16.7 kB 0 B
packages/paste-libraries/dropdown/dist/index.es.js 17.7 kB 0 B
packages/paste-libraries/dropdown/dist/index.js 17.7 kB 0 B
packages/paste-libraries/reakit/dist/index.es.js 28.2 kB 0 B
packages/paste-libraries/reakit/dist/index.js 27.7 kB 0 B
packages/paste-libraries/styling/dist/index.es.js 29.6 kB 0 B
packages/paste-libraries/styling/dist/index.js 30 kB 0 B
packages/paste-style-props/dist/index.es.js 1.93 kB 0 B
packages/paste-style-props/dist/index.js 1.96 kB 0 B
packages/paste-theme/dist/index.es.js 4.3 kB 0 B
packages/paste-theme/dist/index.js 3.85 kB 0 B
packages/paste-types/dist/index.es.js 21 B 0 B
packages/paste-types/dist/index.js 34 B 0 B

compressed-size-action

Comment on lines +44 to +45
minWidth="size10"
zIndex="zIndex20"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be made to popover as well. I'll make a ticket for that.

Copy link
Contributor

@richbachman richbachman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.

@TheSisb TheSisb merged commit a90c739 into master Jul 1, 2020
@TheSisb TheSisb deleted the menu/style-tweaks branch July 1, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants