Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(website): gatsby-image and image plugins #62

Merged
merged 5 commits into from Aug 27, 2019
Merged

feat(website): gatsby-image and image plugins #62

merged 5 commits into from Aug 27, 2019

Conversation

richbachman
Copy link
Contributor

  • Setup assets folder in file system
  • Added:
    • gatsby-image
    • gatsby-plugin-sharp
    • gatsby-remark-images
    • gatsby-transformer-remark
    • gatsby-transformer-sharp

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@vercel
Copy link

vercel bot commented Aug 19, 2019 •
edited

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://paste-git-working-images.twilio-dsys.now.sh

richbachman
richbachman commented Aug 19, 2019
View reviewed changes
packages/paste-website/gatsby-config.js
{
resolve: `gatsby-plugin-mdx`,
options: {
defaultLayouts: {
default: require.resolve('./src/layouts/DefaultLayout.tsx'),
},
gatsbyRemarkPlugins: [{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres a bug in gatsby-plugin-mdx that doesn't allow gatbsy-remark-images to do its thing. Adding gatsby-tranformer-remark solves that issue.

@richbachman richbachman added the Status: WIP This PR is still a work-in-progress. No need to review. label Aug 19, 2019
@richbachman richbachman removed the Status: WIP This PR is still a work-in-progress. No need to review. label Aug 20, 2019
TheSisb
TheSisb reviewed Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested a demo image locally to see if this works? I tried it locally and wasn't able to get it working. Might be helpful to push a demo up with this PR

@richbachman
Copy link
Contributor Author

@TheSisb good call. I'll nail down a couple images to use for a demo. Do you mind providing what you tried locally so I can see how its failing?

@TheSisb
Copy link
Collaborator

TheSisb commented Aug 22, 2019 •
edited

I blew away my changes but I had basically tried this: https://www.gatsbyjs.org/packages/gatsby-image/#how-to-use

I added a photo into assets/images/test.png and verified it showed up in the graphql viewer. Retrieving it in the MDX and showing it was the issue. It didn't show up.

@richbachman richbachman added the Area: Doc Site Related to the documentation website label Aug 27, 2019
TheSisb
TheSisb approved these changes Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke offline and documented on confluence.

@richbachman richbachman merged commit c3e48fd into master Aug 27, 2019
@richbachman richbachman deleted the working-images branch August 27, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiTaggart SiTaggart SiTaggart approved these changes

@TheSisb TheSisb TheSisb approved these changes

Assignees
No one assigned
Labels
Area: Doc Site Related to the documentation website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@richbachman @TheSisb @SiTaggart